extend illegal instruction docs #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
requested changes
Aug 9, 2023
Co-authored-by: Kenneth Hoste <[email protected]>
|
@boegel I added the macro for the default cluster in the text, to make the text easier to read. I also saw that there is a "othercluster" macro that is set to the donphan cluster, but I'm hesitant to use that one, due to the fact that it is not 'required' to be set to a debug/interactive cluster. The links to the interactive/debug cluster would make no sense if someone would change the othercluster to for example 'skitty'. |
boegel
requested changes
Aug 10, 2023
Co-authored-by: Kenneth Hoste <[email protected]>
milachae
force-pushed
the
illegal_instruction
branch
from
76d3d90
to
e8cc867
Compare
boegel
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #535