Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made merge flag configurable #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Made merge flag configurable #8

wants to merge 1 commit into from

Conversation

rbak
Copy link

@rbak rbak commented Apr 1, 2015

No description provided.

@roland-hochmuth
Copy link

This pull request doesn't fix anything. There was a behavior with Grafana for Monaca/InfluxDB 0.8 which displayed multiple metrics. With the support for InfluxDB 0.9 in Monasca the API is no longer capable of returning multiple metrics for the measurements and statistics queries. However, we want the old behavior to work. The proper fix is to query the metrics API first and get a list of metrics back and then query the measurements or statics API for each individual metric and render it in Grafana.

@rbak
Copy link
Author

rbak commented Apr 6, 2015

This pull request was intended to make the merge flag configurable so that grafana could continue being used as it was before the merge flag change was introduced. It sounds like what you're saying is that grafana was not meeting your needs prior to the introduction of the merge flag and requires additional changes. If this is the case we would appreciate being involved in any discussions about these changes since they sound rather large and we would like to preserve the functionality we need in addition to your requirements.

@bklei
Copy link

bklei commented Apr 6, 2015

It does seem like the behavior Roland is describing is beyond the scope of this change, or perhaps an issue with monasca-api when the merge flag isn't passed? I don't recall the specifics of how grafana and monasca-api worked with influxdb 0.8, since we were talking straight to influxdb with that version.

Did the dashboard formerly make the set of multiple calls you are describing? That seems inefficient as opposed to letting the db/api do the combining without multiple REST calls? Maybe I'm not understanding the issue here too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants