Add support for RedHat. #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ice304373166fa045046060a313673c01a15db6a4
| @@ -1,5 +1,36 @@ | |||
| --- | |||
| horizon_path: /opt/stack/horizon/ | |||
| panel_src_path_os: | |||
There was a problem hiding this comment.
There are enough platform specific variables that I think it would be cleaner to setup individual files for them and then at the top of the main task do an include_vars with_first_found statement.
There was a problem hiding this comment.
but vars are hard to overwrite. You could do it in include role but not in host_vars and group_vars. So if we think that some variable could be overwritten we think that better place is defaults/main.
There was a problem hiding this comment.
Good point using include_vars does make them harder to overwrite.
|
Could we please merge that? |
Change-Id: Ibc215389c6760cc4328a56176d933b7629bdc73b
Commit provides Horizon UI is translated properly. Change-Id: Ifb59ed24478a7245ac36bc78e0024a56ecf49e1e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.