This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
WIP: fixed fsnFlags race condition on linux #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Ian. Over at https://github.com/fsnotify/fsnotify (see #101) I've removed WatchFlags entirely, and put together a different strategy for filtering (see fsnotify/fsnotify#7) @howeyc Would you like continued work on bugfixes such as this and #93? |
|
I'm not going to merge this because it looks like it will break on other platforms. However, I will be accepting fixes until there is a package in the standard library. |
|
Thanks @howeyc. I'll try to backport bugfixes where I can. |
|
I'll close this one, but keep #102 then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #102, but only on linux. I'd like to see some comments before fixing it for every platform.