Merge pull request #2 from howardyoo/howardyoo-patch-1

Missing span when using OTEL provider with Airflow 2.10.0
howardyoo · Sep 8, 2024 · 1012568 · 1012568
2 parents 368cc9e + 86c7761
commit 1012568
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/airflow_provider_opentelemetry/airflow_provider_opentelemetry/util.py b/airflow_provider_opentelemetry/airflow_provider_opentelemetry/util.py
@@ -64,12 +64,17 @@ def gen_dag_span_id(dag_run: DagRun, as_int: bool = False) -> str | int:
     )
 
 def gen_span_id(ti: TaskInstance, as_int: bool = False) -> str | int:
+    from packaging.version import parse
     """Generate span id from the task instance."""
     dag_run = ti.dag_run
     if ti.state == TaskInstanceState.SUCCESS or ti.state == TaskInstanceState.FAILED:
         try_number = get_try_number(ti)
     else:
-        try_number = ti.try_number
+        # fix: issue #1
+        if parse(parse(airflow_version).base_version) == parse("2.10.0"):
+            try_number = ti.try_number - 1
+        else:
+            try_number = ti.try_number
     return _gen_id(
         [dag_run.dag_id, dag_run.run_id, ti.task_id, str(try_number)],
         as_int,