Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show error screens for SSL errors when the url matches the current visit #323

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

jayohms
Copy link
Collaborator

@jayohms jayohms commented Mar 20, 2024

This change prevents displaying an error view and resetting the session when a 3rd party resource is requested on a page with an SSL error. Error views should only be displayed when the main visit url fails to load from an SSL error.

…nt visit. This prevents erroring out the entire visit when a 3rd party resource is requested on a page with an SSL error.
@jayohms jayohms merged commit bb636d6 into main Mar 23, 2024
1 check passed
@jayohms jayohms deleted the ssl-errors branch March 23, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant