Fix/event driven tasks continuation #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
|
Please rebase with There are definitely still a few bugs lurking around though - would be really grateful if you can test it out and fix remaining errors! |
spwoodcock
force-pushed
the
feat/event-driven-tasks
branch
from
18ff58c
to
4ceb30d
Compare
|
Oh also, if you get a chance, could you possibly take a look at the Playwright tests? It's probably a simple fix 😄 I'll look into how we get the Entities |
github-actions
bot
added
backend
… fix/event-driven-tasks-continuation
…ssion comments api
spwoodcock
approved these changes
Oct 29, 2024
| @@ -27,7 +27,7 @@ const TaskSelectionPopup = ({ taskId, body, feature }: TaskSelectionPopupPropTyp | |||
| const authDetails = CoreModules.useAppSelector((state) => state.login.authDetails); | |||
| const selectedTask = { | |||
| ...projectData?.[projectIndex]?.taskBoundries?.filter((indTask, i) => { | |||
| return indTask?.index == taskId; | |||
| return indTask?.id == taskId; | |||
There was a problem hiding this comment.
Apologies Nishit, I think I messed up the usage if task id vs index again 😅
spwoodcock
added a commit
that referenced
this pull request
Oct 29, 2024
…actor (#1838) * build: add migrations to update task_history --> task_events * refactor(backend): wip update to use TaskEvent / State enums * refactor(frontend): wip update to use TaskEvent / State enums * build: add trigger to set task_event.state automatically from event * refactor: continued wip to use task events * refactor: fixes to task state/event distinction * fix: additional fixes to backend usage action --> event * build: fix migration conflict if task_history does not exist * build: add conflate to enums in case for future * refactor: further wip updates for task events * refactor(frontend): update enums * feat: set db default for UUID --> gen_random_uuid() * build: fix during development building postgis db images * build: fix migrations * fix: working event creation endpoint on tasks * fix(frontend): update to use new /events endpoint * fix: basemap generation via frontend (use POST) * build: add validation and comment to automatic state trigger func * test: fix task event + comment routes * fix: usage of task events endpoints * fix: activities panel status --> state * build: move api healthcheck to docker-compose file * build: fix up-mapper working with playwright * build: update playwright on mapper frontend to match react frontend * Fix/event driven tasks continuation (#1839) * build: add migrations to update task_history --> task_events * refactor(backend): wip update to use TaskEvent / State enums * refactor(frontend): wip update to use TaskEvent / State enums * build: add trigger to set task_event.state automatically from event * refactor: continued wip to use task events * refactor: fixes to task state/event distinction * fix: additional fixes to backend usage action --> event * build: fix migration conflict if task_history does not exist * build: add conflate to enums in case for future * refactor: further wip updates for task events * fix(taskSelectionPopup): project task index display on task popup * fix(submissionsInfographics): handle undefined task_history * fix(dialogTaskActions): remove taskBoundary from args, pass geojsonStyles to as args * fix(taskEvent): use response state to track and update current task state color * fix(featureSelectionPopup): page crash on taskStateEnum undefined fix * fix(getTaskStatusStyle): update feature style key based on entiy_state enums * fix(projectInfo): change card title accessor key * fix(taskSubmissionsMap): fix taskGeojson schema * fix(submissionDetails): update get comments api * fix(updateReviewStatusModal): update reviewList id, update post submission comments api --------- Co-authored-by: spwoodcock <[email protected]> * fix(backend): fix logic returning all tasks with project * refactor: update logging on task event * build: add NOT NULL constraints to required task_event fields * fix(frontend): marking task as mapped when not all buildings done * fix(frontend): getting task history comments=false, comments=true * fix: enable tasks/activity endpoint until merged with dashboard * build: add Just command to load prod data into current db * fix: use timezone aware timezones from db, fix dashboard api * build: ensure task_events.created_at has timezone * test: fix e2e test expecting 'mapped' when 'unlocked_to_validate' * fix(frontend): bug where task state was not updated in task dialog * fix: remove duplicate use of state selector * test: small fixes to playwright test strings to validate * build: disable ui-mapper in playwright tests for now * build: update cloudflare/cloudflared version 2024.5.0 --> 2024.10.1 * build: simplify justfile command for tunnelling * fix(frontend): check for empty taskId when new geopoint submission * fix: updating review state for a submission --------- Co-authored-by: Nishit Suwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Describe this PR
Frontend fixes based on backend changes.
Screenshots