-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Readme.md #135
Updated Readme.md #135
Conversation
I would recommend adding narrative explanations for the diagrams. They feel (my point of view) bare and the idea behind is not so clear .. However, @kshitijrajsharma and myself should do as we talked about it before. I would suggest you @neelimagoogly try to put a narrative description based on your understanding as a core text. Then I can edit with Kshitij and close the PR |
Done. |
@neelimagoogly
|
Thanks @kshitijrajsharma , I will keep this in mind while creating PRs everytime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to use relative path like this (./docs) instead of full links
In this way user working on any branch can have access to this relatively
This needs to be changed where files are referenced in all over the PR except external links
This assets folder can be used to add pictures and videos to use relative path like this (./assets) instead of full links and user working on any branch can have access to this relatively as suggested .
Updated Readme.md
I have added the diagrams of General Workflow of fAIr and fAIr architecture to the README file wrt #128. @kshitijrajsharma , @omranlm and @petya-kangalova please review it.