feat: Add config option for log level #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
VinozzZ
reviewed
Jan 29, 2024
| @@ -92,6 +92,8 @@ type GlobalOptions struct { | |||
| FilterFiles []string `short:"F" long:"filter-file" description:"Log file(s) to exclude from --file glob. May have multiple values, including multiple globs." yaml:"filter-file,omitempty"` | |||
| RenameFields []string `long:"rename_field" description:"Format: 'before=after'. Rename field called 'before' from parsed lines to field name 'after' in Honeycomb events. May have multiple values." yaml:"rename_field,omitempty"` | |||
|
|
|||
| LogLevel string `long:"log_level" description:"Set the log level. Valid values are 'debug', 'info', 'warn', 'error', 'fatal', 'panic'." default:"info" yaml:"log_level,omitempty"` | |||
There was a problem hiding this comment.
Wow, I didn't know logrus supported fatal and panic levels. I wonder if users would find them useful when using honeytail
There was a problem hiding this comment.
Yeah, probably not. I let Co-Pilot auto generate the comment here 😄
We have log entries for debug, info, error and fatal. We could remove warn and panic as they are unused.
There was a problem hiding this comment.
Coming back to this, I think the comment is valid - panic and warn log levels are valid, we just don't use them at the moment.
VinozzZ
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Honeytail logs a summary of every batch of events sent to Honeycomb. These are very repetitive and obscure other information if there was a problem sending events. The summaries are logged at the
INFOlevel using logrus.This PR adds a log level configuration option that allows users to set their desired log level in the logging framework logrus. The usage of info level was verified to not contain critical information if there was a problem, with more important logs using a higher log level (eg
error).Short description of the changes
log_leveloption, defaulting toinfoThis was tested by setting the
log_levelflag after building the tool locally. As we use flag parsing in main file, it's not easy to write unit tests.