feat: Don't add k8s attributes when source/destination IP matches agent IP #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update libhoney handler to use cache client funcs tidy up
MikeGoldsmith
changed the title
loshz
reviewed
Oct 3, 2023
…to mike/ignore-agent-k8s-attrs # Conflicts: # utils/k8sutils.go
JamieDanielson
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
When processing events, the agent tries to lookup the source and destination IPs in the list of cached k8s pods. However, because the agent uses host network, the agent gets the same IP as the node and any other pods who also use host networking which leads to inconsistent results.
This PR updates event processing to not lookup pod attributes if the source or destination IP matches the agent IP.
Short description of the changes
How to verify that this has the expected result
When processing an event when the source or dest IPs match the agent IP, k8s attributes are no longer added.