Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: update go version and docs #223

Merged
merged 5 commits into from
Oct 16, 2024
Merged

maint: update go version and docs #223

merged 5 commits into from
Oct 16, 2024

Conversation

JamieDanielson
Copy link
Contributor

Which problem is this PR solving?

  • preparation for release

Short description of the changes

  • (try to update licenses, apparently no licenses needed updates for this release but since it took these changes to find that out I figured they were worth keeping)
  • add Makefile based on Refinery's Makefile for easier license updates (and easier testing 😄 )
  • update version in .go-version to match maint(go): update to go1.23 #222
  • update releasing file to use new make targets and add more detail to process
  • add verify-licenses to test step in ci

How to verify that this has the expected result

run the make targets and it should all work

@JamieDanielson
update missed go version to match changes in 222
8ec3267
@JamieDanielson
add makefile for easier test and license updates
e50cd5c 
this was lifted from refinery which has similar needs
@JamieDanielson
update releasing to use new make targets
63143b1 
also add some nice details, also lifted from refinery
@JamieDanielson
add verify-licenses to ci
f336066 
later we can update test steps
@JamieDanielson JamieDanielson requested a review from a team as a code owner October 16, 2024 20:24
@JamieDanielson JamieDanielson self-assigned this Oct 16, 2024
@JamieDanielson JamieDanielson added the type: maintenance The necessary chores to keep the dust off. label Oct 16, 2024
codeboten
codeboten reviewed Oct 16, 2024
View reviewed changes
.go-version Outdated Show resolved Hide resolved
@JamieDanielson JamieDanielson merged commit 550ff37 into main Oct 16, 2024
5 checks passed
@JamieDanielson JamieDanielson deleted the jamie.update-lics branch October 16, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizthegrey lizthegrey lizthegrey approved these changes

@codeboten codeboten codeboten approved these changes

Assignees

@JamieDanielson JamieDanielson

Labels
type: maintenance The necessary chores to keep the dust off.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamieDanielson @codeboten @lizthegrey