Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip failing Python 3.13 tests on musl #279

Draft
wants to merge 1 commit into
base: frenck-2024-0551
Choose a base branch
from

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Oct 11, 2024

No description provided.

@cdce8p cdce8p changed the title Skip failing Python tests on musl Skip failing Python 3.13 tests on musl Oct 11, 2024
@cdce8p
Copy link
Member Author

cdce8p commented Oct 16, 2024

/CC @frenck

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdce8p Why would we add a patch instead of setting the PROFILE_TASK environment variable?

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 18, 2024 15:40
@cdce8p
Copy link
Member Author

cdce8p commented Oct 18, 2024

Why would we add a patch instead of setting the PROFILE_TASK environment variable?

What do you have in mind? Just setting it to an empty sting like the official docker image? That's possible but it also skips the tests entirely. I thought that it might be useful to continue running the tests during the build and therefore only patch the failing ones.

https://docs.python.org/3/using/configure.html#envvar-PROFILE_TASK

https://github.com/docker-library/python/blob/3540d6820a125a6b7dedca00784e0f28cb365c9d/3.13/alpine3.20/Dockerfile#L88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants