Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for HueBLE #5534

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

flip-dots
Copy link

Proposed change

Add icon and logo for the proposed new intergration HueBLE

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

@frenck frenck added the has-parent This PR has a parent PR in a other repo label Jun 3, 2024
Copy link
Contributor

@tr4nt0r tr4nt0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just use the already available Hue Logos? Create a symlink pointing from hue_ble to hue

@flip-dots
Copy link
Author

Maybe just use the already available Hue Logos? Create a symlink pointing from hue_ble to hue

I would have done that but I already spent the effort making the logo for the Python library for the Home Assistant integration and it only took a few minutes to crop it for this and I wanted a little bit of differentiation from the bridge based integration and my Bluetooth based one, and also to highlight my work a little, even though its a minor thing, I can live without it though if its important.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains product images; however, we collect manufacturer branding in this repository. In this case, the Philips Hue branding was expected to be used.

../Frenck

@home-assistant
Copy link

home-assistant bot commented Aug 5, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 5, 2024 10:13
@flip-dots
Copy link
Author

flip-dots commented Aug 11, 2024

This PR contains product images; however, we collect manufacturer branding in this repository. In this case, the Philips Hue branding was expected to be used.

../Frenck

@frenck Phillips do have branding specific to their Bluetooth lights if that works better
image
Let me know if its cool if I use this and ill update it, or if it absolutely has to use the generic branding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants