Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Apply biome import sorting #803

Merged
merged 1 commit into from
Jun 3, 2024
Merged

chore: Apply biome import sorting #803

merged 1 commit into from
Jun 3, 2024

Conversation

manzt
Copy link
Member

@manzt manzt commented Jun 3, 2024

Enables (and enforces) biome's import sorting.

@manzt manzt merged commit fb2f7f0 into main Jun 3, 2024
5 checks passed
@manzt manzt deleted the manzt/organize-imports branch June 3, 2024 12:06
@ilan-gold
Copy link
Collaborator

thanks! def missed this one - googled it and everything, thinking it was true!

@ilan-gold
Copy link
Collaborator

Oh i'm so sorry I was confused. I thought this was for anndata.js! Feel free to reopen!

@manzt
Copy link
Member Author

manzt commented Jun 3, 2024

Lol no worries. I already merged.

I intentionally left import sorting off in #796, to make the PR easier to review. The main change here is just this line in biome.json:

{
  "$schema": "https://biomejs.dev/schemas/1.7.3/schema.json",
  "organizeImports": {
    "enabled": false
  },
  "linter": {
++    "enabled": true,
--    "enabled": false,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants