Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Drift popup code #377

Merged
merged 9 commits into from
Apr 30, 2024
Merged

Added Drift popup code #377

merged 9 commits into from
Apr 30, 2024

Conversation

chandans1316
Copy link
Collaborator

@chandans1316 chandans1316 commented Apr 11, 2024

Issue

Fixes: https://merative.atlassian.net/browse/MERATIVE-885

Description

https://merative.atlassian.net/browse/MERATIVE-885

The existing marketo form block on merative.com/contact needs to be updated with a javascript listener called "fastlane".

Test URLs

Fix: https://merative.atlassian.net/browse/MERATIVE-885

Copy link

aem-code-sync bot commented Apr 11, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync aem-code-sync bot temporarily deployed to issue-885-drift-script April 17, 2024 12:59 Inactive
Copy link

aem-code-sync bot commented Apr 17, 2024

Page Scores Audits Google
/contact PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to issue-885-drift-script April 17, 2024 14:14 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to issue-885-drift-script April 17, 2024 14:16 Inactive
@keith-kaplan keith-kaplan self-requested a review April 23, 2024 15:15
Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not functioning properly. The fastlane playbook does not load. Please look back at the original email from Drift and see if the code that was sent can be implemented in a way that works.

@aem-code-sync aem-code-sync bot temporarily deployed to issue-885-drift-script April 29, 2024 10:39 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to issue-885-drift-script April 29, 2024 10:54 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to issue-885-drift-script April 29, 2024 11:00 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to issue-885-drift-script April 29, 2024 11:56 Inactive
@joehanchoi
Copy link
Collaborator

Form will pause redirect once Playbook chatbot appears now

@keith-kaplan
Copy link
Collaborator

@joehanchoi testing now.

Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this is working. I've used the existing conditions for the fastlane playbook and I can get it fire. We will plan to merge to Main tomorrow when we're on a Drift call. We'll also update the conditions to not using the testing emails.
image

Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested with the updated targeting in Drift. Confirmed it works.

@keith-kaplan keith-kaplan merged commit d0ab297 into main Apr 30, 2024
2 checks passed
@keith-kaplan keith-kaplan deleted the issue-885-drift-script branch April 30, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants