Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-961-CPSfileupdated #375

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Conversation

Ajeet-Nellikeri
Copy link
Collaborator

Issue

Problem/motivation - Our CSP is blocking the script we use for 6Sense. The CSP needs to be updated to correctly deploy script.

Test URLs

Description

Proposed solution
Add *.6sc.co and *.6sense.com to our CSP. The file that needs to be uploaded is here located here - https://github.com/hlxsites/merative2/blob/main/scripts/csp.json
Please add it in: script-src

Update CPS to include 6Sense script
Copy link

aem-code-sync bot commented Apr 3, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Apr 3, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to issue-961-CPS-include-6Sense-script April 3, 2024 14:08 Inactive
Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the CSP errors were fixed for both 6sense scripts and there was a LinkedIn one I fixed. Should be good to merge to main now.

@keith-kaplan keith-kaplan merged commit 950cfa7 into main Apr 3, 2024
2 checks passed
@keith-kaplan keith-kaplan deleted the issue-961-CPS-include-6Sense-script branch April 3, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants