Property Detail page (All blocks) #125
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 25, 2023 10:17
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
|
badvision
reviewed
Jun 1, 2023
| padding-left: 15px; | ||
| } | ||
|
|
||
| @media (min-width: 576px) { |
There was a problem hiding this comment.
Is this breakpoint necessary? The next one up is only ~24px away.
|
|
|
bstopp
requested changes
Jun 5, 2023
There was a problem hiding this comment.
let's start splitting this up into minimal block chunks so that we can identify the root causes of the low PSI score.
Also, the CSS selectors are too generic, they will need to be scoped more specifically to their blocks.
I would also like to work on a way to put all these blocks into a subfolder, and load them in an auto-block fashion. May help with code organization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #11
Test URLs:
List of blocks