Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Open Hive] Add openhive-esp32.ino #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Open Hive] Add openhive-esp32.ino #77

wants to merge 1 commit into from

Conversation

amotl
Copy link
Member

@amotl amotl commented Jun 1, 2023

About

The Arduino firmware for the Open Hive ESP32 appliance.

Details

In order to receive better maintenance, and to improve visibility, @ClemensGruber suggested to assimilate this program into the canonical repository. Thank you.

Origin / Resources

@amotl amotl requested a review from ClemensGruber June 1, 2023 19:51
@amotl
Copy link
Member Author

amotl commented Jun 1, 2023

Naming things

I used openhive-esp32.ino for the name, and discourage to use the more specific hardware peripherals within the name, like TTGO or such. In that spirit, the filename for the .ino file is similar to others in this repository, like bienenwaage-esp32.ino.

The thing is that openhive-wifi-gsm has already been assigned to the other firmware. However, the ESP32 variant is not much different in functionality, right? Also, if LoRa features would be added, you would probably also add them to the openhive-esp32.ino, and not to another different firmware implementation, so it would also make no sense to add the supported telemetry variants to the name, because that may change in the future.

Do you agree?

On a second thought, based on my argument, we could rename the openhive-gsm-wifi slot to openhive-esp8266, because that would actually reflect its content much better, specifically after adding the ESP32 variant.

What do you think about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants