This repository has been archived by the owner on Nov 28, 2018. It is now read-only.
Check for array value before using it #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hildende Hi hildende, do you think this MR is ready for acception? |
lubobill1990
added a commit
to lubobill1990/smtp-mailing-queue
that referenced
this pull request
Jul 30, 2017
…ut inject SMTPMailingQueue to other classes when new instances 2. add changes from hildende#3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Send directly without waiting for cronjob to process queue checkbox isn't checked the value is never POST'ed to the server. In PHP 7 (at least on my development server) that gives me:
This PR checks the array before using it.