Skip to content
This repository has been archived by the owner on Jul 30, 2023. It is now read-only.

diff coloring #77

Closed
oguzyildizz opened this issue Aug 4, 2021 · 3 comments
Closed

diff coloring #77

oguzyildizz opened this issue Aug 4, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@oguzyildizz
Copy link

I think it it would be nice to have diff colors similar to helm diff, currently the entire output looks green

@Wikiwix
Copy link

Wikiwix commented Oct 7, 2022

Depending on the did tool you have configured, adding the option --plain helps. Though I believe for the did command kubecolor should never overwrite the colour, so the issue stays valid

@hidetatz hidetatz added the enhancement New feature or request label Dec 31, 2022
@hidetatz
Copy link
Owner

Let's discuss this in #117

@hidetatz hidetatz closed this as not planned Won't fix, can't repro, duplicate, stale Dec 31, 2022
@Wikiwix
Copy link

Wikiwix commented Dec 31, 2022

@hidetatz In my opinion this is not connected to an overall colour schema.

kubectl diff always displays the output of an external tool which means that kubecolor should never interfere with the colorization that tool may or may not do.

FYI the relevant excerpt of of kubectl diff --help:

Diff configurations specified by file name or stdin between the current online configuration, and the configuration as it would be if applied.

 The output is always YAML.

 KUBECTL_EXTERNAL_DIFF environment variable can be used to select your own diff command. Users can use external commands with params too, example: KUBECTL_EXTERNAL_DIFF="colordiff -N -u"

 By default, the "diff" command available in your path will be run with the "-u" (unified diff) and "-N" (treat absent files as empty) options.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants