Skip to content
This repository has been archived by the owner on Jul 30, 2023. It is now read-only.

Better color schema #117

Open
hidetatz opened this issue Dec 31, 2022 · 3 comments
Open

Better color schema #117

hidetatz opened this issue Dec 31, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@hidetatz
Copy link
Owner

While I believe kubecolor colorizes the kubectl output nicely, I don't think current implementation is best. The better color schema might be found in the future.

Now, there are a lot of color schema change requests:

#110
#102
#91
#89
#88
#77
#76

It will be possible to implement all the things, but I'm concerned the kubecolor will be not very simple and not easy to use. In the first place, this kind of thing is completely personal preference.

In my opinion, we have to options:

  • Keep it simple. No color customization ability in kubecolor. If you don't like it's color schema, you can fork and change it.
  • Make kubecolor configurable. Imagine vim's syntax highlighting configuration. The configuration file will look like this:
# ~/.config/kubecolor/schema.yml
dark: true
color:
  get:
    base_color: blue
    warn_color: red
    highlight_crush_loop_backoff: true
...

Two things on the second option:

  • Will we really want to write this file?
  • What's the format of the file?

I don't want to make kubecolor too complicated, I want to keep it simple as much as possible. However, the really useful feature should be builtin without configuration file.
I want to gather the opinion.

@bcouetil
Copy link

Great, now we are talking 😊

Maybe we could start by the 'why' we (would) use this promising tool. For now I don't.

My 'why' : highlight resources problems with colors.

And I believe it is the case for more than half the issues gathered.

So for me, the minimum would be to differentiate bad/transitioning/good state of each field, whatever the color, but preferably conventional (red/yellow/green).

@AndreSchulz-IONOS
Copy link

Most important: Would be useful to have colored indication of a resource state: STATUS, READY and RESTARTS to see problems easily.

Other than that might be useful to specify custom color by their NAMESPACE and NAME using e.g. a pattern.
So e.g. different color for services, logging, monitoring, DB ...

@tmpm697
Copy link

tmpm697 commented Jul 24, 2023

It'd be better if this program can use/get/inherit colors from neovim's colorscheme?

I have lua colorscheme and want it also in this program instead of current hardcoded colors.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants