Mpi auth #36
Mpi auth #36
Conversation
Coverage report
Show new covered files 🐣
Test suite run success4 tests passing in 2 suites. Report generated by 🧪jest coverage report action from 5ab8ef2 |
|
|
||
| type eLabsStatus = 'PENDING' | 'PROGRESS' | 'COMPLETED'; | ||
|
|
||
| @Controller('mpi') |
There was a problem hiding this comment.
Is there a reason this is written using REST instead of GraphQL?
| import { BadRequestException, Injectable } from '@nestjs/common'; | ||
| import axios from 'axios'; | ||
|
|
||
| // type ELabsStudyResponse = { |
There was a problem hiding this comment.
Is this code still needed if commented out? If so, then the code should have a comment above it explaining why
|
|
||
| // TODO: put this in an env file. | ||
| private client_id = 'tZSXM9f8WUiPIpNGt1kXlGqzZVYvWNEF'; // Auth0 Damp Canvas app client ID | ||
| private client_secret = 'uHw3eZ4XrYcBW1zJJqWt1dbLC6YuwCT-v0AeXa1npLuhiEkw-Ayq1wwDcw3FSgnh'; // Auth0 Damp Canvas app client secret |
| client_id: this.client_id, | ||
| client_secret: this.client_secret, | ||
| code, | ||
| redirect_uri: 'http://127.0.0.1:5100/mpi/auth0_redirect' // URL in this server that was used to redirect to after Auth0 login |
There was a problem hiding this comment.
This should probably be a configuration value
|
|
||
| @Injectable() | ||
| export class MPIService { | ||
| private tokenStore = new Map<string, { accessToken: string; refreshToken: string; accessTokenExpiration: Date }>(); |
There was a problem hiding this comment.
This should probably be within MongoDB since we already have everything setup for it
| const user = this.tokenStore.get(this.currentUserId); | ||
| if (user && user.accessToken && user.accessTokenExpiration) { | ||
| if (user.accessTokenExpiration > new Date(Date.now())) { | ||
| console.log('user ', user, ' has valid token'); |
There was a problem hiding this comment.
Best to avoid having left over console.logs
| async createSequence(): Promise<any> { | ||
| const token = await this.getAccessToken(); | ||
| if (!token) { | ||
| return new BadRequestException('No token found, log in to MPI first'); |
There was a problem hiding this comment.
Ideally this is an Unauthroized exception
| if (!token) { | ||
| return new BadRequestException('No token found, log in to MPI first'); | ||
| } | ||
| const sequences = await axios.get('http://localhost:5000/sequences', { |
There was a problem hiding this comment.
The URL should probably be a config value
| async getSequences(): Promise<any> { | ||
| const token = await this.getAccessToken(); | ||
| if (!token) { | ||
| return new BadRequestException('No token found, log in to MPI first'); |
There was a problem hiding this comment.
Another Unauthorized exception usage
Description
Checklist