Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use already existing cache if found during build #1747

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use already existing cache if found during build #1747

wants to merge 2 commits into from

Commits on Apr 19, 2023

  1. Create failing test

    @camuthig
    camuthig committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    9b667ce View commit details
    Browse the repository at this point in the history

  2. Set cache from read cache files 

    When building a unit registry using a cache, the read cache data is not
getting leveraged. Instead a new cache is getting built, but without the
dimensional equivalents.

This creates a behavior where you create a new UnitRegistry from already
cached files and call `get_compatible_units` it will always fail with
a key error.
    @camuthig
    camuthig committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    a2ed394 View commit details
    Browse the repository at this point in the history