Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature python3 #81

Open
wants to merge 118 commits into
base: master
Choose a base branch
from
Open

Feature python3 #81

wants to merge 118 commits into from

Conversation

elterrien
Copy link

No description provided.

staverne and others added 30 commits April 11, 2020 11:52
Handle session management
Auth revamp
JWT support
(#MOBI-3309) Integrate Beaker middleware with WSGI application
…_domain

(#MOBI-4041) Allow cookie custom domain
…e_lax_for_oauth2_fitbit

(#MOBI-4189) Fix session samesite lax for fitbit oauth2
@staverne
Copy link
Member

Thank's a lot for the works ! I will take time to read/merge/improve the PR.

@@ -36,7 +36,6 @@
urlpattern('/devpanel/classid', ApiDevPanel_ClassidViewList),
urlpattern('/devpanel/classid/{class_id}', ApiDevPanel_ClassidViewDetails),
# Resource
urlpattern('/devpanel/resource/{uuid}', UUIDView),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe its used to remove resource ?


class ExportAsJSONButton(BrowseButton):

title = MSG("Exporter les ressources (JSON)")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME should be in English

self.authenticate()
else:
# The authenticated user
self.authenticate()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the IF

try:
value = self.cookies[name].value
except AttributeError:
value = self.cookies[name]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ?

"""
FORM return example :
{'cls_description': 'Importer des documents bureautiques, des images, des fichiers de média, etc.', 'referrer': 'http://127.0.0.1:8081/', 'data': ('test.txt', 'text/plain', 'test fichier\n\n'), 'title:fr': ''}
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English + check why v1 is obsolete ?

ikaaro/server.py Outdated Show resolved Hide resolved
@@ -338,7 +401,9 @@ def __init__(self, target, read_only=False, cache_size=None,
# Set timestamp
self.timestamp = str(int(time() / 2))
# Load the config
print("TARGET", target)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME

import guppy.heapy.RM
# Package not compatible with python 3
# if profile_space is True:
# import guppy.heapy.RM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@@ -1000,6 +1067,8 @@ class ServerConfig(ConfigFile):
'index-text': Boolean(default=True),
'max-width': Integer(default=None),
'max-height': Integer(default=None),
'accept-cors': Integer(default=1),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default=0

# root.set_value('mtime', time(10, 0))
# except Exception as e:
# pass
# self.assertNotEqual(e, None)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants