Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to token API of <mediawiki-1.27. #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

heroxbd
Copy link

@heroxbd heroxbd commented Dec 20, 2017

On <mediawiki-1.27, the mediawiki-site-get-token will fail. The old
action=login POST method is used instead to obtain login tokens.

Closes: #28

  On <mediawiki-1.27, the mediawiki-site-get-token will fail.  The old
  action=login POST method is used instead to obtain login tokens.

Closes: hexmode#28
@hexmode
Copy link
Owner

hexmode commented Jul 11, 2018

I don't like the blanket ignore-error here. This could hide problems from users of more recent (AKA “supported”) wikis.

Something like this would be acceptable if the error was logged in Messages with a note that the error is being ignored to support pre-1.27 wikis.

@hexmode hexmode force-pushed the master branch 2 times, most recently from b5dcd15 to 5178a1a Compare July 6, 2020 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants