Update jvm.sh to make shellcheck happier #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update jvm.sh to make shellcheck and people running `set -eux` happier no unbound variables and set locals separately from assigning them
Malax
added
the
skip changelog
|
Hi @bf4! Thanks for you contribution! Happy to merge this in after we get CI to pass! We actually have ShellCheck in CI, which version did give you warnings about this? I ran CI for your PR and got formatter lint failures from |
|
Looking at the failures. Sorry for the delay. |
bf4
commented
Jul 27, 2023
bf4
commented
Jul 27, 2023
``` shfmt -f . | grep -v "/vendor/" | xargs shfmt -i 2 -d | git apply ```
This reverts commit 37cc57a.
Malax
approved these changes
Aug 9, 2023
|
Thanks @bf4! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update jvm.sh to make shellcheck and people running
set -euxhappierno unbound variables and set locals separately from assigning them