Hotfix 1.11.1 (#475)

This CR fixes the error on the compilation phase, related to the type checking. We import the module `fs` only for nodejs, it's configured in the package.json file, so we can disable the type checking for the importing in the private class NodeFileData and it's safe. Updated versions and CHANGELOG Resolves: OLPSUP-14784 Signed-off-by: Oleksii Zubko <[email protected]>
heremaps · Jun 17, 2021 · cafa3ba · cafa3ba
1 parent 51b7fb7
commit cafa3ba
Show file tree

Hide file tree

Showing 7 changed files with 246 additions and 226 deletions.
diff --git a/@here/olp-sdk-authentication/test/OAuth.test.ts b/@here/olp-sdk-authentication/test/OAuth.test.ts
@@ -94,7 +94,7 @@ describe("oauth-request-offline", function() {
 
  const options: RequestInit & any = fetchMock.calls()[0][1];
  expect(options.headers.get("Authorization")).to.be.equal(
- `OAuth oauth_consumer_key="mocked-key",oauth_nonce="mocked-nonce",oauth_signature_method="HMAC-SHA256",oauth_timestamp="1550777140",oauth_version="1.0",oauth_signature="v4mS3w5P0ba%2FBmgK2XfS8VzPFy2mUm%2FCZT0KvimSQxo%3D"`
+ `OAuth oauth_consumer_key="mocked-key",oauth_nonce="mocked-nonce",oauth_signature_method="HMAC-SHA256",oauth_timestamp="1550777140",oauth_version="1.0",oauth_signature="PVYijMWSDplONd9abHA8rx3OuHB7NkxfQqE2jw3I%2FE0%3D"`
  );
  });
 

diff --git a/@here/olp-sdk-core/lib.version.ts b/@here/olp-sdk-core/lib.version.ts
@@ -17,4 +17,4 @@
  * License-Filename: LICENSE
  */
 
-export const LIB_VERSION = "1.11.0";
+export const LIB_VERSION = "1.11.1";
diff --git a/@here/olp-sdk-core/package.json b/@here/olp-sdk-core/package.json
@@ -1,10 +1,10 @@
 {
  "name": "@here/olp-sdk-core",
- "version": "1.6.0",
+ "version": "1.6.1",
  "description": "Core features of the HERE Data Platform",
  "main": "index.js",
  "browser": "index.web.js",
- "typings": "index",
+ "typings": "index.web",
  "directories": {
  "test": "test",
  "lib": "lib"

diff --git a/@here/olp-sdk-dataservice-write/lib/utils/multipartupload-internal/NodeFileData.ts b/@here/olp-sdk-dataservice-write/lib/utils/multipartupload-internal/NodeFileData.ts
@@ -17,9 +17,11 @@
  * License-Filename: LICENSE
  */
 
-import { fs } from "@here/olp-sdk-core";
 import { BlobData } from "@here/olp-sdk-dataservice-write";
 
+// @ts-ignore disable typechecking for this line
+import { fs } from "@here/olp-sdk-core";
+
 /**
  * @internal
  * Implementation of reading bytes from file by filepath

diff --git a/@here/olp-sdk-dataservice-write/package.json b/@here/olp-sdk-dataservice-write/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@here/olp-sdk-dataservice-write",
- "version": "1.6.0",
+ "version": "1.6.1",
  "description": "Wrapper around a subset of the HERE Open Location Platform Data REST API related to writing data to OLP catalogs",
  "main": "index.js",
  "browser": "index.web.js",

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,13 @@
+## v1.11.1 (17/06/2021)
+
+**olp-sdk-dataservice-write**
+
+- Disable type checking for line `import { fs } from "@here/olp-sdk-core";` in `NodeFileData` private class.
+
+**olp-sdk-core**
+
+- Change typings settings to `index.web`.
+
 ## v1.11.0 (07/06/2021)
 
 **olp-sdk-dataservice-write**

diff --git a/yarn.lock b/yarn.lock