Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #98 by using async functionality #99

Closed
wants to merge 2 commits into from
Closed

Closes #98 by using async functionality #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b84501e
Closes #98 by using async functionality
seraco Oct 15, 2017
3c5faff
Update Readme.md for helping others to solve a mismatch error
seraco Oct 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ To build for all platforms
```
npm run package-all
```
If there is an error of version mismatch in Electron run
```
node_modules/.bin/electron-rebuild
```
For more information check out [electron-react-boilerplate](https://github.com/chentsulin/electron-react-boilerplate), which we used as a starting point.

## Feature Requests
Expand Down
2 changes: 2 additions & 0 deletions app/app.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
const link = document.createElement('link');
link.rel = 'stylesheet';
link.href = '../dist/style.css';
link.setAttribute('async', '');
document.write(link.outerHTML);
}
}());
Expand All @@ -20,6 +21,7 @@
(function() {
const script = document.createElement('script');
script.src = (process.env.HOT) ? 'http://localhost:3000/dist/bundle.js' : '../dist/bundle.js';
script.setAttribute('async', '');
document.write(script.outerHTML);
}());

Expand Down
2 changes: 1 addition & 1 deletion main.development.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ if (process.env.NODE_ENV !== 'development') {
const createWindow = () => {
mainWindow = new BrowserWindow({
'show': false,
'resizable': false,
'resizable': true,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the relevance of this to the PR?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No relevance at all. The problem was that I am developing on MacOS and I could not see all the content of the window if it was not resizable. You can leave it as before.

'width': 295,
'height': 435,
'titleBarStyle': 'hidden',
Expand Down