-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update everforest themes #11459
Update everforest themes #11459
Conversation
\cc @CptPotato |
I think the diff gutter without background looked a bit cleaner and had good visibility already. But I don't particularly dislike the new one. Styling the table header is a good idea, though I think a background color looks a little out of place here. Maybe bold and underlined could look a bit better here? Using the background color to highlight diagnostics is something I like and do in my personal themes because my terminal doesn't support colored underlines. Though, it's a matter of preference and some users might find it too distracting. All in all, I'm not necessarily against these changes but maybe there are other users who use this theme that can give a second opinion. |
I don't think a theme should be setting the background color for any in-text highlights. That is known to cause issues with some UI elements like cudor line and I also find too distracting. Usually I don't comment about that in a eeview since themes are personal but I actually use everforest so I don't think I would want to see that change here. I also prefer the diff gutter without the background color but I am not quite as opposed to that as it doesnt interfere with other ui elements. |
* stylize v2 picker columns
I've updated the branch so that the only changes are in the styling of the picker headers. |
Thanks, and sorry for the nit-picking. |
Hi! I made this changes so that the git diff and lsp warnings are more visible, and the column names of the new picker are differentiated from the data.