Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python #119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Python #119

wants to merge 2 commits into from

Commits on Feb 13, 2022

  1. Fix compilation with protoc 

    Without package defined in all .proto files, output generation fails, e.g.

  joshua@cryptodevs[proto] protoc -I src --cpp_out=cpp src/*.proto
  blockchain_block_v1.proto:20:12: "blockchain_txn" is not defined.
  blockchain_block.proto: Import "blockchain_block_v1.proto" was not
  found or had errors.
  blockchain_block.proto:6:17: "blockchain_block_v1" is not defined.

- With package defined, resolve conflict between enum and package namespace

  radio.proto:3:9: "helium.radio" is already defined
  (as something other than a package) in file
  "blockchain_txn_poc_receipts_v1.proto".

- In src/service/gateway.proto, resolve warning on unused import
    @thecardcheat
    thecardcheat committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    2b1a987 View commit details
    Browse the repository at this point in the history

  2. Python build

    @thecardcheat
    thecardcheat committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    3669386 View commit details
    Browse the repository at this point in the history