Two phase commit for mobile packet verifier #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ALTER TABLE data_transfer_sessions RENAME TO old_data_transfer_sessions; | ||
| ALTER TABLE data_transfer_sessions_by_row to data_transfer_sessions; | ||
| DROP TABLE data_transfer_sessions; |
There was a problem hiding this comment.
don't you mean DROP TABLE old_data_transfer_sessions?
Comment on lines
+111
to
+112
| .bind(&session.payer) | ||
| .bind(session.uploaded_bytes) |
There was a problem hiding this comment.
you're missing the bind on num_dcs
| .execute(pool) | ||
| for pending_txn in pending_txns { | ||
| let txn: Signature = pending_txn.signature.parse()?; | ||
| let mut transaction = self.pool.begin().await?; |
There was a problem hiding this comment.
i don't think you ever commit this transaction. does it need to be inside this for loop or can it be a single transaction for all of the pending_txns?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to figure out how to get the migration for this to work