frontend: Add crosslinks from CR additional printercolumns to secrets #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: guilhane <[email protected]>
Guilamb
changed the title
illume
reviewed
Oct 8, 2024
There was a problem hiding this comment.
Thanks @Guilamb, I appreciate it. We can take this PR over from here.
It looks like to keep the CI happy these stories should have a state added for the secret so there is a link:
- headlamp/frontend/src/components/crd/CustomResourceList.stories.tsx
- headlamp/frontend/src/components/crd/CustomResource.stories.tsx
To generate the snapshots again... npm run test -- -u
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the additional printer column of a CRD contains the "secret" keyword, then display an hyperlink to the secret page in the same namespace.
Fix #2278
Signed-off-by: guilhane [email protected]