Add support for yosys and iverilog on osx arm64 #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several bugs in `abc` that cause it to cast `unsigned` to `int`. The Conda version of clang doesn't like this, and generates an error. The default yosys build for clang adds this argument, however the conda-eda version of the Makefile was missing it. This fixes builds on arm64. Signed-off-by: Sean Cross <[email protected]>
Previously, yosys on osx was using clang 4.0. However, 12.0 and 14.0 are the only versions of clang available to conda on arm64. Use the latest version. This is available for both x64 and arm64. Signed-off-by: Sean Cross <[email protected]>
There are two changes that are necessary to get arm64 compatibility working on osx: 1. The configure script needs to be regenerated, and 2. The clang version needs to be bumped. A new configure script has been submitted for inclusion upstream. Patch the existing one while we wait for it to get merged. Signed-off-by: Sean Cross <[email protected]>
|
cc @proppy |
|
@PiotrZierhoffer @ajelinski do we have some CI environment for osx/arm64? |
|
@proppy @xobs only GitHub runners, vide https://github.com/hdl/conda-eda/blob/master/.github/workflows/Build.yml#L335-L342 |
|
Yes, that's x64 not arm64. The magical incantation to switch to arm64 is |
proppy
reviewed
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for building these packages on arm64 versions of macos.
Note that the biggest change is the clang compiler -- only clang 12 and clang 14 are available in conda, so I picked the latest available version.