-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore diff in blank lines when posting issue back to github #6819
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Anna Khismatullina <[email protected]>
.split('\n') | ||
.map((it) => it.trimEnd()) | ||
.join('\n') | ||
const normalizeLineEndings = (str: string) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If comments will not be supported we will potentially break description on github, let's support html/comments first and then add a trim of lines >2 into 1 into comparison, but not allow without line and with line be the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fyi: even with this change description with comment and without comment will not be equal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not ready to merge it before comments will be supported.
@haiodo
This PR has fix only for №1: №2 is in progress Are you OK with this fix for №1 only? |
Ignore diff in blank lines when posting issue back to github
Huly®: UBERF-8367