Ignore diff in blank lines when posting issue back to github #6819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Khismatullina <[email protected]>
haiodo
reviewed
Oct 5, 2024
| .split('\n') | ||
| .map((it) => it.trimEnd()) | ||
| .join('\n') | ||
| const normalizeLineEndings = (str: string) => |
There was a problem hiding this comment.
If comments will not be supported we will potentially break description on github, let's support html/comments first and then add a trim of lines >2 into 1 into comparison, but not allow without line and with line be the same.
There was a problem hiding this comment.
Just fyi: even with this change description with comment and without comment will not be equal.
haiodo
requested changes
Oct 5, 2024
|
@haiodo
This PR has fix only for №1: №2 is in progress Are you OK with this fix for №1 only? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore diff in blank lines when posting issue back to github
Huly®: UBERF-8367