Externalise backport action #1373
Open
+56
−285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JackPGreen
added a commit
to JackPGreen/hazelcast-platform-operator-docs
that referenced
this pull request
Nov 13, 2024
The back porting logic is integrated into each action, duplicated [many times across the codebase](https://github.com/search?q=org%3Ahazelcast+%22Checkout+maintenance+branch+and+cherry-pick%22&type=code). In hazelcast/hz-docs#1373 this was centralised. - updated actions to use it - simplified actions - updated the list of supported maintenance branches - *note* this was very outdated
JackPGreen
added a commit
to JackPGreen/management-center-docs
that referenced
this pull request
Nov 13, 2024
The back porting logic is integrated into each action, duplicated [many times across the codebase](https://github.com/search?q=org%3Ahazelcast+%22Checkout+maintenance+branch+and+cherry-pick%22&type=code). In hazelcast/hz-docs#1373 this was centralised. - updated actions to use it - simplified actions - updated the list of supported maintenance branches - *note* this was very outdated and the formatting appeared to be incorrect
JackPGreen
requested review from
oliverhowell,
amandalindsay and
Rob-Hazelcast
as code owners
amandalindsay
approved these changes
Nov 13, 2024
nishaatr
requested changes
Nov 13, 2024
JackPGreen
added a commit
to JackPGreen/hazelcast-platform-operator-docs
that referenced
this pull request
Nov 14, 2024
The back porting logic is integrated into each action, duplicated [many times across the codebase](https://github.com/search?q=org%3Ahazelcast+%22Checkout+maintenance+branch+and+cherry-pick%22&type=code). In hazelcast/hz-docs#1373 this was centralised. - updated actions to use it - simplified actions - updated the list of supported maintenance branches - *note* this was very outdated
nishaatr
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The back porting logic is integrated into each action, duplicated many times across the codebase.
Instead, the logic should be externalised to be re-used.
Changes:
checkoutdone only if requiredACTOR(ie commit author) vs hardcoded 🤖Tested via a dummy repo.