Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small CDC connector fixes #1339

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

TomaszGaweda
Copy link
Contributor

  • use hazelcast-enterprise instead of hazelcast oss
  • java 17 used

@devOpsHazelcast
Copy link
Collaborator

devOpsHazelcast commented Oct 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for hardcore-allen-f5257d ready!

Name Link
🔨 Latest commit 8cca098
🔍 Latest deploy log https://app.netlify.com/sites/hardcore-allen-f5257d/deploys/671f651f7c4726000822bc75
😎 Deploy Preview https://deploy-preview-1339--hardcore-allen-f5257d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TomaszGaweda TomaszGaweda changed the base branch from main to v/5.5 October 21, 2024 18:36
Copy link
Contributor

@frant-hartm frant-hartm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The artifact hazelcast-enterprise-cdc-debezium is in our private repository. It should be mentioned and it should be present in the pom/gradle script. Otherwise the build fails.

@TomaszGaweda
Copy link
Contributor Author

@frant-hartm sorry I've forgot that. I've added to all existing pom.xml / build.gradle + added in the overall setup guide.

@oliverhowell
Copy link
Contributor

Can you look at the Common datatypes mapping table as I think there's some errors:
image
If you check the build log you should see:

10:47:18 AM: [09:47:18.499] ERROR (asciidoctor): dropping cells from incomplete row detected end of table
10:47:18 AM:     file: docs/modules/integrate/pages/cdc-connectors.adoc:254
10:47:18 AM:     source: https://github.com/hazelcast/hz-docs (branch: main | start path: docs)
10:48:24 AM: [09:48:24.350] ERROR (asciidoctor): dropping cells from incomplete row detected end of table
10:48:24 AM:     file: docs/modules/integrate/pages/cdc-connectors.adoc:254
10:48:24 AM:     source: https://github.com/hazelcast/hz-docs (branch: v/5.5 | start path: docs)

@TomaszGaweda
Copy link
Contributor Author

This should be resolved @oliverhowell
image

@oliverhowell
Copy link
Contributor

Thanks @TomaszGaweda I can see the build errors are gone from log too

@TomaszGaweda TomaszGaweda merged commit e2d02c7 into hazelcast:v/5.5 Oct 30, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants