Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the javadoc link for the new client #1321

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

ihsandemir
Copy link
Contributor

@ihsandemir ihsandemir commented Oct 14, 2024

Fıxed the javadoc link for the new client.

@ihsandemir ihsandemir added this to the 5.5 milestone Oct 14, 2024
@ihsandemir ihsandemir self-assigned this Oct 14, 2024
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for hardcore-allen-f5257d ready!

Name Link
🔨 Latest commit 7852d01
🔍 Latest deploy log https://app.netlify.com/sites/hardcore-allen-f5257d/deploys/670d269472fce40008bf7986
😎 Deploy Preview https://deploy-preview-1321--hardcore-allen-f5257d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/modules/clients/pages/java.adoc Outdated Show resolved Hide resolved
@@ -16,10 +17,10 @@ NOTE: Where there are specific differences between {java-client} and {java-clien

// check production recommendation

Both native ({java-client}) and standalone ({java-client-new}) clients enable you to use the Hazelcast API, with this page explaining any differences or technical details that affect usage. This page should be read alongside the respective Javadoc-generated API documentation available from within your IDE and the following links:
Both platform ({java-client}) and standalone ({java-client-new}) clients enable you to use the Hazelcast API, with this page explaining any differences or technical details that affect usage. This page should be read alongside the respective Javadoc-generated API documentation available from within your IDE and the following links:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change because we don't want to say 'native'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because native has other meanings such as Native memory, HD.

docs/modules/clients/pages/java.adoc Outdated Show resolved Hide resolved
@oliverhowell oliverhowell added the backport to 5.5 Backport commits from main to v/5.5 label Oct 14, 2024
Copy link
Contributor

@oliverhowell oliverhowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ihsandemir

@ihsandemir ihsandemir merged commit cc978f7 into hazelcast:main Oct 14, 2024
4 of 6 checks passed
@ihsandemir ihsandemir deleted the new_client_javadoc branch October 14, 2024 14:12
github-actions bot pushed a commit that referenced this pull request Oct 14, 2024
Fıxed the javadoc link for the new client.

---------

Co-authored-by: Oliver Howell <[email protected]>
(cherry picked from commit cc978f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to 5.5 Backport commits from main to v/5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants