Change some leftover references from external data store to data connection #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Data connection feature was called external data store in its beta phase (in Hazelcast 5.3). Apparently there are still some references to the old name left. I have tried to capture everything, apart from the names of the pages / links - I don't understand how the redirects work exactly and didn't want to break anything.
frant-hartm
requested review from
oliverhowell and
amandalindsay
as code owners
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
oliverhowell
approved these changes
Oct 7, 2024
| @@ -45,11 +45,11 @@ p.readFrom(Sources.jdbc( | |||
| )).writeTo(Sinks.logger()); | |||
| ``` | |||
|
|
|||
| You can also use a configured xref:external-data-stores:external-data-stores.adoc#defining-external-data-stores[external data store] as a JDBC Source: | |||
| You can also use a configured xref:external-data-stores:external-data-stores.adoc#defining-external-data-stores[data connection] as a JDBC Source: | |||
There was a problem hiding this comment.
This page doesn't exist...looks like data-connections-configuration.adoc has the alias and the link should still work
There was a problem hiding this comment.
The link does still work, but the updated link text wasn't showing up in the build for some reason. I've just updated all these xrefs (and any child section refs) to point to the new file.
Co-authored-by: Oliver Howell <[email protected]>
amandalindsay
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data connection feature was called external data store in its beta phase (in Hazelcast 5.3). Apparently, there are still some references to the old name left.
I have tried to capture everything, apart from the names of the pages / links - I don't understand how the redirects work exactly and didn't want to break anything.