-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Debezium 2.x docs #1149
Add Debezium 2.x docs #1149
Conversation
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this; most of the comments are just to change text to the new product variables.
Let me know if I have misunderstood or misrepresented anything in my suggestions and we can discuss.
@@ -1,4 +1,4 @@ | |||
= CDC Connector | |||
= Legacy CDC Connector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
= Legacy CDC Connector | |
= {open-source-product-name} CDC Connector |
@@ -0,0 +1,165 @@ | |||
= CDC Connector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
= CDC Connector | |
= {enterprise-product-name} CDC Connector |
for the _streaming of changes from databases_, which can be efficiently | ||
processed by the Jet engine. | ||
|
||
Implementation of CDC in Hazelcast Enterprise is based on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation of CDC in Hazelcast Enterprise is based on | |
Implementation of CDC in Hazelcast {enterprise-product-name} is based on |
processed by the Jet engine. | ||
|
||
Implementation of CDC in Hazelcast Enterprise is based on | ||
link:https://debezium.io/[Debezium 2.x]. Hazelcast offers a generic Debezium source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link:https://debezium.io/[Debezium 2.x]. Hazelcast offers a generic Debezium source | |
link:https://debezium.io/[Debezium 2.x]. Hazelcast offers a generic Debezium source, |
|
||
Implementation of CDC in Hazelcast Enterprise is based on | ||
link:https://debezium.io/[Debezium 2.x]. Hazelcast offers a generic Debezium source | ||
which can handle CDC events from link:https://debezium.io/documentation/reference/2.7/connectors/index.html[any database supported by Debezium], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which can handle CDC events from link:https://debezium.io/documentation/reference/2.7/connectors/index.html[any database supported by Debezium], | |
which can handle CDC events from link:https://debezium.io/documentation/reference/2.7/connectors/index.html[any database supported by Debezium, window=_blank]. |
Co-authored-by: rebekah-lawrence <[email protected]>
Co-authored-by: rebekah-lawrence <[email protected]>
# Conflicts: # docs/modules/integrate/partials/nav.adoc # docs/modules/pipelines/pages/cdc.adoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not sure if you know @TomaszGaweda, but this is my final week at Hazelcast - I'm approving as all looks good - but just shout if you make further changes and want me to look again before Friday.
Thank you - fantastic work as a single-person team on this!
Thanks for great suggestions @oliverhowell! I've applied basically all of them + addressed migration guide vs tips |
Thanks @TomaszGaweda - one final suggestion then (and one that is still unresolved). |
Co-authored-by: Oliver Howell <[email protected]>
Co-authored-by: Oliver Howell <[email protected]>
@oliverhowell We can merge this PR if recent changes are ok with you. Is backport process automated like in hazelcast-mono or manual? |
Not had a chance to review your latest changes yet - when do you need it merged by? |
@oliverhowell Would be great to merge it next week, as 5.5.2 should be released after DevDays. No worries, no hurry, I just want to make sure everything is there :) |
Co-authored-by: Oliver Howell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay getting to these @TomaszGaweda - hopefully most of these are minor and easy to commit. Will take another look when we have a new build but let's get this merged today if poss!
Co-authored-by: Oliver Howell <[email protected]>
Co-authored-by: Oliver Howell <[email protected]>
All applied, good suggestions - thank you @oliverhowell! |
Co-authored-by: rebekah-lawrence <[email protected]> Co-authored-by: Oliver Howell <[email protected]> (cherry picked from commit 50480ef)
Co-authored-by: rebekah-lawrence <[email protected]> Co-authored-by: Oliver Howell <[email protected]>
No description provided.