Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grep: invalid option -- P error on Mac #9

Merged
merged 8 commits into from
Aug 16, 2024
Merged

Fix grep: invalid option -- P error on Mac #9

merged 8 commits into from
Aug 16, 2024

Conversation

JackPGreen
Copy link
Contributor

Fixes #7 (comment)

@JackPGreen @ldziedziul
Fix Grep on Mac
60c1ab4 
Co-Authored-By: Łukasz Dziedziul <[email protected]>
@JackPGreen JackPGreen self-assigned this Aug 16, 2024
ldziedziul
ldziedziul approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@ldziedziul ldziedziul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,

BTW could you change assertion message?

-  local MSG="Expected PR Number extracted from \"$commit_msg\""
+  local MSG="Expected PR Number extracted from \"$commit_msg\" should be equal to \"$expected_pr_number\""

@JackPGreen
Copy link
Contributor Author

Looks good,

BTW could you change assertion message?

-  local MSG="Expected PR Number extracted from \"$commit_msg\""
+  local MSG="Expected PR Number extracted from \"$commit_msg\" should be equal to \"$expected_pr_number\""

f7c6ad6

@JackPGreen JackPGreen merged commit 5961b27 into hazelcast:master Aug 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldziedziul ldziedziul ldziedziul approved these changes

Assignees

@JackPGreen JackPGreen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grep: invalid option -- P error on Mac
2 participants
@JackPGreen @ldziedziul