Merge raisesCondition() into raises() using Class<T>.
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`EitherType` attempts to unify the left type first, so it will match `T` if possible, and default to `Any` if not. This only works when `type` comes before `condition`, and since both arguments are optional, it's possible the user will pass only the function, which will be incorrectly interpreted as being `type`, so we have to check for that. Arguably, the same can be said of `msgNotThrown`.
Previously, Haxe typed it as `haxe.Exception`, so couldn't assign other values to it on static targets. Shadowing the variable is the simplest way around this. And it should be declared above `checkCondition()`. Whoops.
JavaScript, where types are functions...
Now Haxe will be able to correctly interpret each argument, so we don't have to check `isFunction()`, so JS will work again.
player-03
changed the title
raisesCondition into raises using Class<T>.raisesCondition() into raises() using Class<T>.
|
Closing this to keep the discussion in one place: #127 |
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Assert.raises()took parametertype:Any, but I've changed it totype:Class<T>. In theory this is a breaking change, but I argue that it almost certainly won't break any code in practice because there was no use case for passing anything other than aClass.typegets passed toStd.isOfType(), so if it was anything other than aClass, the assertion would always fail, prompting the user to fix the error. Now, the prompt will happen at compile time rather than runtime.This pull request is an alternative to #127. The two are similar, but this one is shorter, requires less documentation, and works in more versions of Haxe.