Use enum abstract where available.
#122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This syntax was added in Haxe 4.0, and Haxe 4.3 has begun emitting warnings.
AlexHaxe
reviewed
Aug 15, 2023
src/utest/utils/TestBuilder.hx
Outdated
Comment on lines
12
to
13
| #if !haxe4 @:enum #end | ||
| private #if haxe4 enum #end abstract IsAsync(Int) { |
There was a problem hiding this comment.
I find using two surgical conditional sections while solving the issue it also make it way harder to read.
surely noone is a fan of duplicating code, but I think in this case it would be much clearer and more acceptable if it was something like:
#if haxe4
private enum abstract IsAsync(Int) {
var Yes = 1;
var No = 0;
var Unknown = -1;
}
#else
@:enum
private abstract IsAsync(Int) {
var Yes = 1;
var No = 0;
var Unknown = -1;
}
#endThere was a problem hiding this comment.
personally I don't like conditionals mixed with code lines, but I can't speak for the maintainers. I don't know what they find acceptable / prefer.
|
Fixed in #124. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old syntax is deprecated as of Haxe 4.3.