Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly parse array in sanitize function #157

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

nihauc12
Copy link
Contributor

proposition of fix for #156

I've also simplified a bit the sanitizeResource function and added some tests.

Note that this change should be considered major in versionning since it breaks backward compatibility.

before:

sanitizeResource([0, 1, 2]) == { 0: 0, 1: 1, 2: 2}

after:

sanitizeResource([0, 1, 2]) == [0, 1 ,2]

@JosepC12
Copy link

looks good!

@nihauc12
Copy link
Contributor Author

nihauc12 commented Jul 6, 2023

@praveenweb 👋 any news on this :) ?

@praveenweb praveenweb merged commit bcb19b3 into hasura:master Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants