Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fromList docs #500

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Improve fromList docs #500

merged 2 commits into from
Jul 26, 2024

Conversation

AlexMaryW
Copy link
Contributor

Issue: #439

Hi, I wrote the documentation on the basis of issue comments and put it in all six definitions of fromList :)

@lehins lehins requested a review from Shimuuar July 25, 2024 17:18
lehins
lehins approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.
While we are at improving the fromList haddock, I thought we could also add the since pragmas, hence the suggestions.

vector/src/Data/Vector/Unboxed.hs Show resolved Hide resolved
vector/src/Data/Vector.hs Show resolved Hide resolved
vector/src/Data/Vector/Primitive.hs Show resolved Hide resolved
vector/src/Data/Vector/Storable.hs Show resolved Hide resolved
vector/src/Data/Vector/Generic.hs Show resolved Hide resolved
@AlexMaryW
Copy link
Contributor Author

Thanks! I added the suggested pragmas in be318c1.

@Shimuuar
Copy link
Contributor

LGTM. Thank you! I think this PR is good to go

@Shimuuar Shimuuar merged commit fd76994 into haskell:master Jul 26, 2024
22 checks passed
@Shimuuar Shimuuar mentioned this pull request Jul 26, 2024
Closed
@TeofilC
Copy link

TeofilC commented Jul 26, 2024

Thanks @AlexMaryW !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shimuuar Shimuuar Shimuuar approved these changes

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexMaryW @Shimuuar @TeofilC @lehins