You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This relates to this comment here. Specifically, these tests use property-based testing to exercise all the stated laws of MonadAccum, with a large enough test count to be meaningful.
@andreasabel I mostly tagged you as a reviewer because you suggested/requested some tests. Was this what you had in mind?
I started with MonadAccum for two reasons: it's one of the (currently only two) type classes provided by mtl which even states any laws, and of the two, it is by far the easiest, both in terms of the laws themselves, and also to test.
I started with MonadAccum for two reasons: it's one of the (currently only two) type classes provided by mtl which even states any laws, and of the two, it is by far the easiest, both in terms of the laws themselves, and also to test.
Testing the laws is of course the gold standard!
Even simple unit tests that cover the functionality are useful, detecting basic problems like missing exports, unintended loops, etc.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to this comment here. Specifically, these tests use property-based testing to exercise all the stated laws of
MonadAccum, with a large enough test count to be meaningful.