Fix string encodings. #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately testing this is quite non-trivial due to the fact that |
maoe
reviewed
May 18, 2020
|
I'll take over this PR. |
Previously we used the Binary instance for Text to serialise the event name. This is wrong. We now first encode to UTF-8 and use this in the eventlog encoding.
This test fails due to haskell#14. Until it's fixed we disable the test.
|
Confirmed that all tests (excluding the disabled ones) passed in #65. Merging. |
|
Thanks @maoe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used the Binary instance for Text to serialise the event
name. This is wrong.
We now first encode to UTF-8 and use this in the eventlog encoding.