Use esbuild #1807
Merged
Use esbuild #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
force-pushed
the
use_esbuild
branch
2 times, most recently
from
d18b042
to
c482dc1
Compare
This replaces webpack with esbuild for building or bundling the extension in both development or deployment workflows for both the desktop and web versions of this extension. This improves the speed of building and bundling the extension, reduces the size of the output, and simplifies the build process. This required changing the build scripts, the npm tasks, adding a new esbuild.js file, and updating the package.json file to include the necessary dependencies. The result is a much faster build process that is more reliable and easier to maintain, without changing the core npm script commands. In addition to esbuild, this updates the versions of eslint, prettier, and eslint rulesets. This required some updates to existing files to conform to the rulesets. This is a follow-up to #1761 which configured webpack to use esbuild instead of a typescript loader. While that PR did improve the speed of the build, it still used webpack which is just not as fast as esbuild.
ansgarm
approved these changes
Jul 30, 2024
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces webpack with esbuild for building or bundling the extension in both development or deployment workflows for both the desktop and web versions of this extension. This improves the speed of building and bundling the extension, reduces the size of the output, and simplifies the build process.
This required changing the build scripts, the npm tasks, adding a new esbuild.js file, and updating the package.json file to include the necessary dependencies. The result is a much faster build process that is more reliable and easier to maintain, without changing the core npm script commands.
In addition to esbuild, this updates the versions of eslint, prettier, and eslint rulesets. This required some updates to existing files to conform to the rulesets.
This is a follow-up to #1761 which configured webpack to use esbuild instead of a typescript loader. While that PR did improve the speed of the build, it still used webpack which is just not as fast as esbuild.