Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DNS query backoff for load balanced environments #230

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wolffberg
Copy link

When updating a load balanced DNS environment the provider might see a inconsistent result on apply as it will query a different DNS server from the one it pushed updates to immidiately after pushing the update.

This PR provides a minimal invasive way of handling backoff by re-using the already existing retries value (although potentionally looping over the remaining retries multiple times) while only having to modify the update functions.

Also removed a broken IP hashing test.

Closes: #89

net.ParseIP no longer supports parsing IP addresses with leading zeroes: golang/go#30999
@wolffberg
Copy link
Author

@apparentlymart you were involved with #89 some years ago (sorry for the ping if this is no longer the case 😊)
Do you mind taking a look at this workaround?

@wolffberg
Copy link
Author

@bendbennett @bflad @SBGoods
Hi guys,
This PR is slowly drifting into conflict-hell 🔥
Any way you could look into either getting it merged (would be happy to fix the conflicts first) or implementing a backoff in some other way?
The backoff is the only way we can apply consistently.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TF 0.12 Provider produced inconsistent result
1 participant