Implement DNS query backoff for load balanced environments #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
net.ParseIP no longer supports parsing IP addresses with leading zeroes: golang/go#30999
wolffberg
force-pushed
the
dns-backoff
branch
from
b4d693a
to
f47d15e
Compare
|
@apparentlymart you were involved with #89 some years ago (sorry for the ping if this is no longer the case 😊) |
|
@bendbennett @bflad @SBGoods |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating a load balanced DNS environment the provider might see a inconsistent result on apply as it will query a different DNS server from the one it pushed updates to immidiately after pushing the update.
This PR provides a minimal invasive way of handling backoff by re-using the already existing
retriesvalue (although potentionally looping over the remaining retries multiple times) while only having to modify theupdatefunctions.Also removed a broken IP hashing test.
Closes: #89