Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase - Add a demo of RichTooltip applied to and within a Dropdown #2534

Closed
wants to merge 1 commit into from

Conversation

didoo
Copy link
Contributor

@didoo didoo commented Oct 31, 2024

📌 Summary

Small PR to add a demo of the RichTooltip applied to a Dropdown, and within a Dropdown.

Preview: https://hds-showcase-git-showcase-richtooltip-on-dropdown-hashicorp.vercel.app/components/rich-tooltip#demo

Context: https://hashicorp.slack.com/archives/C025N5V4PFZ/p1730399280118789?thread_ts=1730398843.741169&cid=C025N5V4PFZ

📸 Screenshots

Applied to Dropdown:
image

Within Dropdown:
image


👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

@didoo didoo requested review from alex-ju and a team October 31, 2024 18:57
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Oct 31, 2024 6:57pm
hds-website ✅ Ready (Inspect) Visit Preview Oct 31, 2024 6:57pm

Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this – it helped us understand the current behavior of a RichTooltip on a Dropdown however I don't think we're aiming to support these use cases (at least not yet). The first example renders a button within a button and the second one, as you mentioned, is a bad idea.

@didoo didoo closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants