Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enterprise Nav - Remove AppSideNav & AppHeader related components from template registry #2528

Closed
wants to merge 2 commits into from

Conversation

KristinLBradley
Copy link
Contributor

@KristinLBradley KristinLBradley commented Oct 30, 2024

STATUS: Closed as removing components from the registry introduces errors from the linter.


📌 Summary

If merged, this PR will remove AppSideNav & AppHeader related components from the template registry.


👀 Component checklist

  • Percy was checked for any visual regression
  • [ ] A changelog entry was added via Changesets if needed (see templates here)

💬 Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ❌ Failed (Inspect) Oct 30, 2024 9:23pm
hds-website ❌ Failed (Inspect) Oct 30, 2024 9:23pm

@didoo
Copy link
Contributor

didoo commented Oct 31, 2024

@KristinLBradley can you add a comment on why the ticket was closed, for future reference/knowledge? Thanks 🙏

@KristinLBradley
Copy link
Contributor Author

Ticket closed as removing components from the template registry introduces linting errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants